Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2443 pyvis three minor enhancements #2444

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

duxans
Copy link
Contributor

@duxans duxans commented Dec 7, 2023

Fixes

This PR resolves #2443

What does this PR do?

3 minor improvements for better workflow and network visualization:

  • iterating over set(tools) for tool in set(tools): instead of for tool in tools: to avoid unecessary overwriting iterations. The same for notebooks for-loop.
  • remove physics=False leaving the default True for all regular tool nodes. This was set to False causing undesired freezing movement for two of the tool nodes.
  • change the string title for the edges that shows up when hovering with the cursor. Instead of the "action" string now will show the shorter and more informative "notebook_url" string.

Screenshots

Provide supporting docs, limitations if any, video of the template, or anything that you want to share to support your PR

@jravenel jravenel changed the title #2443 pyvis three minor enhancements fix: #2443 pyvis three minor enhancements Dec 8, 2023
@FlorentLvr FlorentLvr merged commit 26118e2 into master Dec 11, 2023
9 checks passed
@FlorentLvr FlorentLvr deleted the #2443-pyvis-three-minor-enhancements branch December 11, 2023 08:19
Copy link

The template is now available on the master branch on this link:
https://github.com/jupyter-naas/awesome-notebooks/blob/master/Pyvis/Pyvis_Visualize_awesome_notebooks_network.ipynb

Copy link

Thank you for your contribution @duxans, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

![duxans.png](error code: 521)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyvis - Three minor enhancements
2 participants